Skip to content

Conversation

@br3aker
Copy link
Contributor

@br3aker br3aker commented Jan 5, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #1900.

I've actually found another image from fuzz issue which has 131 components and was throwing InvalidImageContentException. Moved it to the NotSupportedException test suite.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1924 (22ed6da) into master (5fa5e50) will increase coverage by 0%.
The diff coverage is 75%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1924   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         966     966           
  Lines       51350   51353    +3     
  Branches     6401    6402    +1     
======================================
+ Hits        45214   45217    +3     
  Misses       5076    5076           
  Partials     1060    1060           
Flag Coverage Δ
unittests 88% <75%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 89% <66%> (+<1%) ⬆️
src/ImageSharp/Formats/Jpeg/JpegThrowHelper.cs 63% <100%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa5e50...22ed6da. Read the comment docs.

@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Jan 6, 2022
@JimBobSquarePants JimBobSquarePants merged commit a54a19f into SixLabors:master Jan 6, 2022
@br3aker br3aker deleted the dp/sof-exception-fix branch January 6, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jpeg unhandled System.ArgumentException with malformed image

3 participants