Support frames metadata for Identify #2363
Conversation
|
I’m sorry I’m late. @JimBobSquarePants I make without a global change of API, affecting only tiff metadata. At the moment, it is relevant only for tiff images. There is a way to add frames metadata into |
| /// <value> | ||
| /// The frames. | ||
| /// </value> | ||
| public IReadOnlyList<TiffFrameMetadata> Frames { get; set; } = Array.Empty<TiffFrameMetadata>(); |
There was a problem hiding this comment.
If you look at how this is done with our Gif format you will see that the individual frame metadata is not a property of the main image one.
They're stored in a dictionary within individual ImageFrameMetadata instances.
There was a problem hiding this comment.
Just realized what you mean by this.
I've pulled your code down and will work on a refactor to add the info to ImageInfo
There was a problem hiding this comment.
I've pulled your code down and will work on a refactor to add the info to
ImageInfo
yes, this way looks more mature
JimBobSquarePants
changed the title
|
@IldarKhayrutdinov I've updated your PR to add support for Gif also. Thanks for making a start on this, it made the feature much, much easier to implement! |
JimBobSquarePants
added
formats:gif
area:metadata
breaking
| /// </summary> | ||
| /// <param name="minCodeSize">Minimum code size of the data.</param> | ||
| /// <param name="length">The resulting index table length.</param> | ||
| public void SkipIndices(int minCodeSize, int length) |
There was a problem hiding this comment.
Gif doesn't tell you in advance the length of the combined LZW segment blocks. You have to read each one which must be decoded to read the next one.
| // Interpret the code | ||
| if (code > availableCode || code == endCode) | ||
| { | ||
| break; |
There was a problem hiding this comment.
This break here is the killer. A lot of properties we require for each loop follow.
| /// <summary> | ||
| /// Extension methods for <see cref="ImageFrameCollection{TPixel}"/>. | ||
| /// </summary> | ||
| public static class ImageFrameCollectionExtensions |
There was a problem hiding this comment.
This is required because ImageFrameCollection<TPixel> implements both IEnumerable<ImageFrame> via inheritance and IEnumerable<ImageFrame<TPixel>>. You have to awkwardly cast to use Select and Where etc.
Select can easily be pollyfilled but an attempt to polyfill Where or other members of System.Linq will clash to it's easier to add a single AsEnumerable<TPixel> method which can then be chained against for the System.Linq methods.
I don't have time, thanks for finishing! |
| /// <summary> | ||
| /// 32 bits per pixel. One byte for each color channel. | ||
| /// </summary> | ||
| Bit32 = 32, |
There was a problem hiding this comment.
I added value for 32 bit
There was a problem hiding this comment.
Ace thanks!
I've also added Bit64 and wired the encoder to default to Bit32 if that is given.
Prerequisites
Description
Fixes for #2286
TiffMetadataforIdentify.InkSetproperty toTiffFrameMetadata, for identification of CMYK images.TiffMetadata./cc @brianpopow
Update.
This PR has been expanded to add a new
IReadOnlyList<ImageFrameMetadata> FrameMetadataCollectiontoImageInfoand updated the gif decoder to also populate this property.