ISSUE #2385 - Implementing try get pattern to TryFindFormatByFileExtension(string extension, [NotNullWhen(true)] out IImageFormat? format)

[Ollie-Ave]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

An issue was raised recently (#2385) Implementing try get pattern to public bool TryFindFormatByFileExtension(string extension, [NotNullWhen(true)] out IImageFormat? format). This PR simply removes Guard.NotNullOrWhiteSpace(extension, nameof(extension)); on line 105 in amendment to this.

I have also added a check for null or whitespace before the check for the presence of a '.' character to prevent out of range exceptions.

if (!string.IsNullOrWhiteSpace(extension) && extension[0] == '.')
{
    extension = extension[1..];
}

I have not edited any other code and there were no extra Unit Test failures after this change was made (1 unit test was failing before any changes were made to the branch)

[CLAassistant]

All committers have signed the CLA.

[JimBobSquarePants]

@Ollie-Ave

Thanks for this. That's a neat fix 👍

Was that locally failing test the memory one? The test explorer in VS doesn't respect the conditional value on the query. It works via dotnet test.

[bjkippax]

@JimBobSquarePants no failures as far as I am aware but I will let @Ollie-Ave follow-up with you.

What's your release schedule?

[Ollie-Ave]

@JimBobSquarePants
It was, the test name was GC_Collect_OnHighLoad_TrimsEntirePool. After running a dotnet test, all tests are passing. Good to know for future contributions.

Thanks for the speedy response with this issue as a whole.

[JimBobSquarePants]

What's your release schedule?

You'll be able to access this release now on our nightly feed.

[Ollie-Ave]

What's your release schedule?

You'll be able to access this release now on our nightly feed.

When will this be available via NuGet?

[JimBobSquarePants]

I don’t know. We only released v3.0.0 a few days ago so will likely capture a few more issues first. This is non-critical so does not require immediate release

[Ollie-Ave]

Fair enough, thanks for your help!