Use more accurate bit for alpha lookup. #2473
Merged
+209
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
4 tasks
antonfirsov
approved these changes
Jun 13, 2023
| /// </para> | ||
| /// </remarks> | ||
| private unsafe struct ColorDistanceCache : IDisposable | ||
| { | ||
| private const int IndexBits = 5; | ||
| private const int IndexAlphaBits = 5; | ||
| private const int IndexAlphaBits = 6; |
There was a problem hiding this comment.
This could be zero when TPixel doesn't have an alpha. It might be worth to eventually implement some trick to have two versions of EuclideanPixelMap, so we save memory when working with RGB pngs and gifs.
There was a problem hiding this comment.
Good point. We could easily preserve much more accurate matches in less space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #2469
Our pixel map accuracy wasn't good enough for alpha comparison, so we were leaving artifacts.
This increases memory from 2.26MB to 4.45MB but not only do we fix our issue, as a result of the increased accuracy, we're also getting less collisions in our RGB components.