Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse automatic include behavior. #2515

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Reverse automatic include behavior. #2515

merged 1 commit into from
Aug 17, 2023

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Aug 17, 2023 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #2466

Reverses the behavior of our global includes to require an explicit <UseImageSharp>true</UseImageSharp> tag.

Breaking but I think necessary.

@JimBobSquarePants JimBobSquarePants added the breaking Signifies a binary breaking change. label Aug 17, 2023
@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Aug 17, 2023
@dlemstra
Copy link
Member

Do we also need to update some documentation that contains this information?

@JimBobSquarePants
Copy link
Member Author

I didn't document it but will for v3.1

@JimBobSquarePants JimBobSquarePants merged commit e81efa3 into main Aug 17, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/reverse-implicit-usings branch August 17, 2023 12:21
@JimBobSquarePants JimBobSquarePants mentioned this pull request Oct 23, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra approved these changes

@tocsoft tocsoft Awaiting requested review from tocsoft

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
breaking Signifies a binary breaking change.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Ambiguous reference between 'Microsoft.Maui.Graphics.Color' and 'SixLabors.ImageSharp.Color'
2 participants
@JimBobSquarePants @dlemstra