Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boxed quantization and update refs #2582

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix boxed quantization and update refs #2582

merged 1 commit into from
Nov 20, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes an issue identified by @mrange in #2549 whereby the bounds were not correctly calculated when quantizing.

@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Nov 16, 2023
@mrange
Copy link

mrange commented Nov 18, 2023

Thanks for looking into this :)

@JimBobSquarePants JimBobSquarePants merged commit c5cc7a7 into main Nov 20, 2023
22 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-quantizer-in-box branch November 20, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocsoft tocsoft Awaiting requested review from tocsoft

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
area:quantizers bug
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JimBobSquarePants @mrange