Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read resolution from EXIF metadata in WebP #2598

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Read resolution from EXIF metadata in WebP #2598

merged 2 commits into from
Dec 1, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

All of the other decoders will use metadata from Exif profiles to populate the ImageMetadata resolution if available. WebP should do the same.

Test values have been confirmed using ExifTool.

@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Nov 30, 2023
@JimBobSquarePants
Copy link
Member Author

Thanks @tocsoft !!

@JimBobSquarePants JimBobSquarePants merged commit 0b36698 into main Dec 1, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/resolution branch December 1, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocsoft tocsoft tocsoft approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
formats:webp metadata:exif
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JimBobSquarePants @tocsoft