Skip to content

V4 - Correctly handle transform spaces when building transform matrices. #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2024
Merged

V4 - Correctly handle transform spaces when building transform matrices. #2795

merged 3 commits into from
Aug 17, 2024

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Aug 17, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #2753

Merges #2791 into main for V4

@JimBobSquarePants JimBobSquarePants added bug area:transforms breaking Signifies a binary breaking change. labels Aug 17, 2024
@JimBobSquarePants JimBobSquarePants added this to the v4.0.0 milestone Aug 17, 2024
@JimBobSquarePants JimBobSquarePants merged commit 7f720db into main Aug 17, 2024
@JimBobSquarePants JimBobSquarePants deleted the js/affine-bounds-fixes branch August 17, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:transforms breaking Signifies a binary breaking change. bug

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Rotation of AffineTransform seems to offset the image by 1 pixel

2 participants

@JimBobSquarePants