Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #576, using explicit struct layout for bgr24 and rgb24 #591

Merged
merged 6 commits into from
May 24, 2018

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR addresses to fix the issue that ImageCloneTests.CloneAs_ToBgr24() was failing sporadically.
rgb24 struct was also changed, because it may also be affected by this issue.

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #591 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   88.73%   88.78%   +0.04%     
==========================================
  Files         854      854              
  Lines       36172    36172              
  Branches     2620     2620              
==========================================
+ Hits        32099    32114      +15     
+ Misses       3290     3275      -15     
  Partials      783      783
Impacted Files Coverage Δ
src/ImageSharp/PixelFormats/Bgr24.cs 80% <ø> (+4%) ⬆️
src/ImageSharp/PixelFormats/Rgb24.cs 77.55% <ø> (ø) ⬆️
tests/ImageSharp.Tests/Image/ImageCloneTests.cs 100% <ø> (+24.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74495d6...2956d42. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unksipped CloneAs_ToBgr24. We should merge this, if the build succeeds,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants