NRT #34
NRT #34
Conversation
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
==================================
- Coverage 20% 19% -1%
==================================
Files 4 4
Lines 352 346 -6
Branches 88 85 -3
==================================
- Hits 71 68 -3
+ Misses 281 278 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@JimBobSquarePants I think this needs to be merged first. After this changes are in the repo my PR with nullable changes should hopefully compile. (IT works on my machine ;) ) |
* Added CallerArgumentExpression to auto infer paramName * Added NotNull Attribute to tell the compiler that the parameter is not null when the method return * Removed unused method * Add nullable to the test project
|
@JimBobSquarePants This could be the next step for NRT. But because of the Conditional Attribute the ArgumentNullException will not be thrown in Release builds. Is this intended? |
|
I’m not sure I understand your question? We have to guard classes. |
|
The DebugGuard will only execute while Debugging. So in release mode the method will not be executed and no ArgumentNullException will be thrown. Perhaps a NullReferenceException when the value is used which was passed to the DebugGuard. Perhaps after finishing NRT the DebugGuard.NotNull can be removed because everything is "hopefully" save ;) |
|
That’s by design. We don’t want DebugGuard running in release mode. Yeah agreed. It’s likely with the proper nullable fixes we won’t even require it. |
2 participants
Contains work for SixLabors/ImageSharp#2236