Rewrite init() so it accepts initialized plugins instead of object-names

fixes #10
SjonHortensius · Feb 22, 2016 · d051d6a · d051d6a
1 parent eb3c941
commit d051d6a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ Using LRTEditor is easy; include the files and configure the highlighter:
 	window.addEventListener('load', function(){
 		LRTEditor.initialize(
 			document.getElementsByTagName('code')[0],
-			['MinimalPlugin', 'UndoPlugin', 'HighlightPlugin'],
+			[LRTEditor_MinimalPlugin, LRTEditor_UndoPlugin, LRTEditor_HighlightPlugin],
 			{
 				highlightCallback: function(el){ sh_highlightElement(el, sh_languages['php']); },
 			}

diff --git a/index.html b/index.html
@@ -18,7 +18,7 @@
 		window.addEventListener('load', function(){
 			LRTEditor.initialize(
 				document.getElementsByTagName('code')[0],
-				['MinimalPlugin', 'UndoPlugin', 'HighlightPlugin'],
+				[LRTEditor_MinimalPlugin, LRTEditor_UndoPlugin, LRTEditor_HighlightPlugin],
 				{
 					highlightCallback: function(el){ sh_highlightElement(el, sh_languages['php']); },
 				}

diff --git a/src/LRTEditor.js b/src/LRTEditor.js
@@ -16,17 +16,21 @@ var LRTEditor = {};
 		highlightCallback: function(){}
 	};
 
-	this.initialize = function(el, _plugins, c)
+	this.initialize = function(el, plugins, c)
 	{
 		this.element = el;
 
 		for (var k in c)
 			this.config[k] = c[k];
 
-		_plugins.forEach(function(p){
-			plugins[p] = window['LRTEditor_' +p];
+		for (var p in plugins)
+		{
+			// fallback for strings instead of objects, fixes #10
+			if ('object' != typeof plugins[p])
+				plugins[p] = window['LRTEditor_' +plugins[p]];
+
 			plugins[p].initialize(this);
-		}.bind(this));
+		}
 
 		this.element.setAttribute('contentEditable', 'true');
 		this.element.setAttribute('autoComplete', 'off');