Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Cleanup build script, use XCFramework #61

Closed
wants to merge 14 commits into from
Closed

[wip] Cleanup build script, use XCFramework #61

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7d6ef31
Remove unneeded flags for ./configure
jurvis Apr 9, 2022
a3976b0
Update flags for latest ios/simulator archs
jurvis Apr 9, 2022
5dfde8f
Add libsecp256k1.a to Xcode project
jurvis Apr 9, 2022
6d1bcab
Use xcodebuild instead of lipo
jurvis Apr 9, 2022
cd21774
Use vendored frameworks in podspec
jurvis Apr 9, 2022
4588994
[wip] checkout libwally-core test_build_fix
jurvis Apr 9, 2022
4050ff7
Update libwally-core
jurvis Apr 12, 2022
de7ecc9
Remove whole module optimization
jurvis Apr 12, 2022
16cbc4f
Remove flags
jurvis Apr 12, 2022
248a124
Add xcframework to preserve_paths
jurvis Apr 12, 2022
dde977c
try different build flags
jurvis Apr 12, 2022
b7e97ef
Make CLibwally imports @_implementationOnly
jurvis Apr 13, 2022
188794c
Try new podspec
jurvis Apr 13, 2022
60ed50a
test with only_active_arch
jurvis Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions build-libwally.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ set -e # abort if any command fails
device=0
simulator=0
clean=0
PROJ_DIRECTORY=`pwd`
BIN_OUTPUT_DIRECTORY="`pwd`/build"

while getopts "h?dsc" opt; do
case "$opt" in
Expand Down Expand Up @@ -33,6 +35,8 @@ if [ $device == 1 ] && [ $simulator == 1 ]; then
echo "Build libwally-core for device and simulator and combine into a single library..."
fi

rm -rf build

cd CLibWally/libwally-core

if [ $clean == 1 ]; then
Expand Down Expand Up @@ -62,12 +66,17 @@ if [ $simulator == 1 ]; then
fi
fi
make
if [ $device == 1 ]; then
cp src/.libs/libwallycore.a build/libwallycore-simulator.a
cd $PROJ_DIRECTORY
xcodebuild archive -scheme LibWally -destination "generic/platform=iOS Simulator" -archivePath ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-Sim CLANG_ADDRESS_SANITIZER=NO CLANG_ADDRESS_SANITIZER_ALLOW_ERROR_RECOVERY=NO CLANG_ADDRESS_SANITIZER_USE_AFTER_SCOPE=NO SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6d1bcab nit: maybe put CLANG_ADDRESS_SANITIZER etc on new lines

if [ $device != 1 ]; then
xcodebuild -create-xcframework \
-framework ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-Sim.xcarchive/Products/Library/Frameworks/LibWally.framework \
-output ${BIN_OUTPUT_DIRECTORY}/LibwallySwift.xcframework
fi
fi

if [ $device == 1 ]; then
cd CLibWally/libwally-core
set +v
if [ ! -d "build" ] || [ $clean == 1 ]; then
echo "Configure and cross-compile for the device..."
Expand All @@ -82,17 +91,25 @@ if [ $device == 1 ]; then
fi
make
set +v
if [ $simulator == 1 ]; then
cd $PROJ_DIRECTORY
xcodebuild archive -scheme LibWally -destination "generic/platform=iOS" -archivePath ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-iOS ENABLE_BITCODE=NO CLANG_ADDRESS_SANITIZER=NO CLANG_ADDRESS_SANITIZER_ALLOW_ERROR_RECOVERY=NO CLANG_ADDRESS_SANITIZER_USE_AFTER_SCOPE=NO SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES
if [ $simulator != 1 ]; then
set -v
cp src/.libs/libwallycore.a build/libwallycore-device.a
xcodebuild -create-xcframework \
-framework ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-iOS.xcarchive/Products/Library/Frameworks/LibWally.framework \
-output ${BIN_OUTPUT_DIRECTORY}/LibwallySwift.xcframework
fi
fi

set +v
if [ $device == 1 ] && [ $simulator == 1 ]; then
echo "Combine simulator and device libraries..."
set -v
lipo -create build/libwallycore-device.a build/libwallycore-simulator.a -o src/.libs/libwallycore.a

xcodebuild -create-xcframework \
-framework ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-iOS.xcarchive/Products/Library/Frameworks/LibWally.framework \
-framework ${BIN_OUTPUT_DIRECTORY}/LibwallySwift-Sim.xcarchive/Products/Library/Frameworks/LibWally.framework \
-output ${BIN_OUTPUT_DIRECTORY}/LibwallySwift.xcframework
fi

set +v
Expand Down