[wip] Cleanup build script, use XCFramework #61
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,8 +50,8 @@ if [ $simulator == 1 ]; then | |
| if [ ! -d "build" ]; then | ||
| echo "Configure and compile for the simulator..." | ||
| set -v | ||
| export CFLAGS="-O3 -arch arm64 -arch x86_64 -fembed-bitcode-marker -mios-simulator-version-min=11.0 -isysroot `xcrun -sdk iphonesimulator --show-sdk-path`" | ||
| export CXXFLAGS="-O3 -arch arm64 -arch x86_64 -fembed-bitcode-marker -mios-simulator-version-min=11.0 -isysroot `xcrun -sdk iphonesimulator --show-sdk-path`" | ||
| mkdir -p build | ||
|
|
||
| ./configure --disable-shared --host=aarch64-apple-darwin --enable-static --disable-elements | ||
|
|
@@ -72,8 +72,8 @@ if [ $device == 1 ]; then | |
| if [ ! -d "build" ] || [ $clean == 1 ]; then | ||
| echo "Configure and cross-compile for the device..." | ||
| set -v | ||
| export CFLAGS="-O3 -arch arm64 -fembed-bitcode -mios-version-min=11.0 -isysroot `xcrun -sdk iphoneos --show-sdk-path`" | ||
| export CXXFLAGS="-O3 -arch arm64 -fembed-bitcode -mios-version-min=11.0 -isysroot `xcrun -sdk iphoneos --show-sdk-path`" | ||
|
There was a problem hiding this comment. a3976b0: If you bump the minimum version, don't forget to update the Podspec. For my own app (nthKey) I'm also fine with a bump to 15.0 if there's any benefit. But I don't know if anyone else is using LibWally-Swift and needs support for older versions of iOs. There was a problem hiding this comment. I see. I bumped to 11.0 because 10.3 was the last supported iOS for There was a problem hiding this comment. think it will be nice to keep it at a generous minimum version, since developers may want to support them |
||
| mkdir -p build | ||
| ./configure --disable-shared --host=aarch64-apple-darwin --enable-static --disable-elements | ||
| if [ $clean == 1 ]; then | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7d6ef31: why would this work on an intel mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, it probably won't. I just hard-coded it for now and can fix it later 😄