-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftPM Support #73
base: master
Are you sure you want to change the base?
Conversation
4270628
to
de143c7
Compare
Add Package.swift
de143c7
to
659a776
Compare
Package.swift
Outdated
import PackageDescription | ||
|
||
let tag = "0.0.7" | ||
let checksum = "62aca7cefdf59cfe96d152e12cfd56387e9960e99523527ff478508f70ac25da" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does this checksum allow others to verify that binary is generated from the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately not, the xcframework
builds are non-deterministic, so they do change between builds. I'm currently working on a bunch of CI actions so we won't have to do releases manually + users won't have to trust us.
we did something over at https://github.com/lightningdevkit/ldk-swift/actions/runs/2819921873 where we use CI to build releases that...
- Generates the XCFramework
- Calculates the checksum of the framework from step 1 and use it to modify lines 4 and 5 here
- Publishes the release
Though, of course, it does mean that users will have to trust GitHub. But I think it is Good Enough™ to get a SwiftPM option to work nicely, while keeping Cocoapods around for developers who prefer a more "do it yourself" option.
What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, as long as we make it clear in the documentation (README?) that using SwiftPM means trusting Github.
Update checksum
cherry picked from #69. wip.
Test Plan
Sjors/libwally-swift
Sjors/libwally-swift