Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftPM Support #73

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jurvis
Copy link
Contributor

@jurvis jurvis commented May 2, 2022

cherry picked from #69. wip.

Test Plan

  • Upload SwiftPM release to Sjors/libwally-swift
  • Update Package.swift to point to Sjors/libwally-swift

@jurvis jurvis force-pushed the jurvis/swiftpm-support branch from de143c7 to 659a776 Compare September 12, 2022 21:20
Package.swift Outdated
import PackageDescription

let tag = "0.0.7"
let checksum = "62aca7cefdf59cfe96d152e12cfd56387e9960e99523527ff478508f70ac25da"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this checksum allow others to verify that binary is generated from the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately not, the xcframework builds are non-deterministic, so they do change between builds. I'm currently working on a bunch of CI actions so we won't have to do releases manually + users won't have to trust us.

we did something over at https://github.com/lightningdevkit/ldk-swift/actions/runs/2819921873 where we use CI to build releases that...

  1. Generates the XCFramework
  2. Calculates the checksum of the framework from step 1 and use it to modify lines 4 and 5 here
  3. Publishes the release

Though, of course, it does mean that users will have to trust GitHub. But I think it is Good Enough™ to get a SwiftPM option to work nicely, while keeping Cocoapods around for developers who prefer a more "do it yourself" option.

What are your thoughts?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, as long as we make it clear in the documentation (README?) that using SwiftPM means trusting Github.

Update checksum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants