Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM node ( memory ) leak #30

Open
olivierchatry opened this issue Aug 16, 2018 · 1 comment
Open

DOM node ( memory ) leak #30

olivierchatry opened this issue Aug 16, 2018 · 1 comment

Comments

@olivierchatry
Copy link
Collaborator

to clear event listener we are using mousetrap._handleKeyEvent which is actually not defined ( it is private to the library ).

so basically, when assigning on a component, we will be leaking DOM nodes because of that.

The only way I can see to do that is to clone moustrap somewhere, add a function to cleanup ( moving the cleanup code from this addon to mousetrap ), create a PR and wait for it to be accepeted.

In the mean time, we can use the cloned moustrap to fix this issue.

@olivierchatry
Copy link
Collaborator Author

ccampbell/mousetrap#427

olivierchatry added a commit that referenced this issue Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant