Allow configuring OpsGenie domain #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guxlightyear
changed the title
|
Fantastic just what I was thinking about doing! thanks @guxlightyear 💯 |
guxlightyear
commented
Nov 5, 2021
| @@ -8,9 +8,9 @@ import { OutputStream } from "../lib/output-stream"; | |||
|
|
|||
| const pageSize = 100; // The max. | |||
|
|
|||
| async function listAlerts(query: string, offset: number, apiKey: string, options: any): Promise<any[]> { | |||
There was a problem hiding this comment.
apiKey was actually not used in the method (it is part of the Options argument).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the issue I posted in #1
This PR adds an extra optional configuration on the CLI, to select a different domain to issue OpsGenie requests to. It is necessary when working on OpsGenie EU, since it uses a different domain (api.eu.opsgenie.com).
Tested it locally, and it works as expected.