Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for some 1.9+ mobs seems bugged #110

Closed
TheBentoBox opened this issue Jun 22, 2016 · 12 comments
Closed

Support for some 1.9+ mobs seems bugged #110

TheBentoBox opened this issue Jun 22, 2016 · 12 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@TheBentoBox
Copy link
Member

Support for shulkers and polar bears in dev17 seems to be broken. They both also return "creature" as their entity type when doing something like send "%player's target%". Tested both on my public server (7 versions behind) and on my test server with the newest Spigot build.

@biscuut
Copy link

biscuut commented Jun 27, 2016

Not to mention ShulkerBullets too. Its as if they weren't added to the entity alias list, I cant do simple things like: Spawn a shulker at the player, since the shulker is not recognised

@bensku
Copy link
Member

bensku commented Jun 29, 2016

Hmm. Probably a bug.

@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 29, 2016
@TheBentoBox
Copy link
Member Author

I can confirm that the code for strays does generally work (spawn a stray at the player spawns one). Looking at one and doing send "%target%" still just sends "skeleton", but that's not as important.

@biscuut
Copy link

biscuut commented Jul 7, 2016

Also stuff like push player's target upwards at speed 2 will push polar bears up and other mobs

@TheBentoBox
Copy link
Member Author

@bensku Do you expect this to be fixed in the next release? I have a fun script idea that relies on polar bears being supported 😊

@bensku
Copy link
Member

bensku commented Jul 10, 2016

I managed to fix shulkers and their bullets, but for some reason Skript refuses to parse polar bear as entity type even after I have verified that it is registered.

Why? Well, due to too much spaghetti code, but I don't know exactly why. For exact same reason why it took me 4 hours to figure out why Skript didn't spawn any entities in certain conditions, it is kinda hard to fix issues like these.

@TheBentoBox
Copy link
Member Author

TheBentoBox commented Jul 10, 2016

I guess on the bright side that means for now we can check if "%event-entity%" is "creature" to see if it's a polar bear. Right now that doesn't work because shulkers also label as creature, but it'll work if they're the only broken entity.

Glad shulkers are working at least! Hope you're able to find the rest of the problem eventually.

@TheBentoBox
Copy link
Member Author

TheBentoBox commented Jul 17, 2016

I'm still having this issue with all 1.9+ mobs and variants (save strays) in dev18b, am trying here. Running this version of Spigot. Very strange!

For now I'm able to detect the difference between shulkers and polar bears via SkStuff by checking if the mob has the Shulker-unique tags, so this isn't personaly a massively huge priority or anything, but should probably be addressed in the near future.

@TheBentoBox
Copy link
Member Author

TheBentoBox commented Jul 19, 2016

Scratch my last comment, I had an extra SkQuery API jar lying around that was causing the issue. I have more info now :)

spawn a shulker now works. Using send "%target%" on a shulker returns "entities.golem.name"

spawn a polar bear doesn't work, BUT spawn a polar bears does. It needs to be plural to work. send "%target%" on a polar bear returns "polar bear", as expected.

So in summary, the current issues left for full 1.10 entity support are:

  1. No husk support.
  2. Shulker name returns as entities.golem.name
  3. Polar bears need to be spawned with polar bears in plural. This applies to all forms of referencing them (e.g. need to do if clicked entity is a polar bears)

@bensku
Copy link
Member

bensku commented Jul 30, 2016

Some of what you meantioned are indeed bugs... But other things do work for me. I need to debug more :)

@bensku
Copy link
Member

bensku commented Sep 1, 2016

This is finally fixed in next release.

bensku added a commit that referenced this issue Sep 1, 2016
@TheBentoBox
Copy link
Member Author

Thank you :)

@bensku bensku closed this as completed Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

3 participants