Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity type comparison #2213

Closed
andrei923 opened this issue Jun 29, 2019 · 5 comments
Closed

Entity type comparison #2213

andrei923 opened this issue Jun 29, 2019 · 5 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@andrei923
Copy link

Description

when you use the code from below and shoot a snowball it returns "no"

Steps to Reproduce

on projectile hit:
	if event-projectile is snowball:
		broadcast "yes %event-projectile%"
	else:
		broadcast "no, %event-projectile%"

Errors / Screenshots

none

Server Information

  • Server version/platform: spigot 1.13.2
  • Skript version: v2.4-alpha4
@ShaneBeee
Copy link
Contributor

if you do if type of event-projectile is snowball it works fine

@TheBentoBox TheBentoBox added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Jul 8, 2019
@TheBentoBox
Copy link
Member

I imagine this is indicative of other entity comparison issues? We should investigate further.

Will note that we do have the relatedEntity set up properly for the snowball item alias here so this shouldn't be due to the alias overlapping.

@TheBentoBox TheBentoBox added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Jul 8, 2019
@ghost
Copy link

ghost commented Jul 18, 2019

Similar thing with looped items;

loop all dropped items:
    if item of loop-entity is a gold ingot:
        if name of item of loop-entity contains "Gold":

that is the only way to get information of the entity itself, not just 'dropped item'. It's a bit confusing.

@Beaness
Copy link

Beaness commented Aug 6, 2019

I can reproduce this.
With type of event-projectile it works fine.

@Whimsyturtle Whimsyturtle changed the title Entity check problem Entity type comparison Oct 17, 2019
@ShaneBeee
Copy link
Contributor

Closing this in favour of #2637
There are many issues on the tracker all stemming from this one big issue, so I wanted to condense this into one larger issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

4 participants