Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event-key which returns the pressed hotbar key on inventory click event #2643

Closed
nopeless opened this issue Nov 11, 2019 · 2 comments
Closed

Add event-key which returns the pressed hotbar key on inventory click event #2643

nopeless opened this issue Nov 11, 2019 · 2 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@nopeless
Copy link

The current on inventory click event doesn't have any values for the key in which the user pressed.
I think it would be a good enhancement to put some sort of event-key.
I'm currently using skript-mirror getHotbarButton() for this value.
@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Nov 11, 2019
@Whimsyturtle Whimsyturtle mentioned this issue Nov 13, 2019
Merged
bensku pushed a commit that referenced this issue Dec 14, 2019
@Whimsyturtle @bensku
InventoryClickEvent Hotbar Button (PR #2648, issue #2643)
f732a88 
* InventoryClickEvent#getHotbarButton()

* Revert Changes

* Create ExprHotbarButton.java

* Clean Imports
@NickAcPT
Copy link
Contributor

NickAcPT commented Dec 15, 2019 •
edited
Loading

This was implemented on PR #2648 (which was merged). Someone please close this.

@TheBentoBox
Copy link
Member

No, we don't close issues until a release has been published with the resolution applied. I'll mark as completed but it will remain open until that time.

@TheBentoBox TheBentoBox added the completed The issue has been fully resolved and the change will be in the next Skript update. label Dec 15, 2019
@Whimsyturtle Whimsyturtle reopened this Dec 22, 2019
@bensku bensku closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bensku @TheBentoBox @Whimsyturtle @ShaneBeee @NickAcPT @nopeless