Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tempban effect in 2.5 #2667

Closed
Jayderp opened this issue Dec 2, 2019 · 4 comments
Closed

add tempban effect in 2.5 #2667

Jayderp opened this issue Dec 2, 2019 · 4 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Jayderp
Copy link

Jayderp commented Dec 2, 2019

how it works:
tempban %player% [(by reason of|because [of]|on account of|due to) %string%] (with (length|duration)|to (durate) the length of) %timespan%
@Jayderp
Copy link
Author

Jayderp commented Dec 2, 2019

it will temporarily ban the specified player for the length of a specified timespan, if there is no timespan it will return an error

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Dec 2, 2019 •
edited
Loading

In my opinion, rather than adding a new effect, I would like to see an optional time span added to the current ban effect.

ex:
Current ban effect:
ban %texts/offline players% [(by reason of|because [of]|on account of|due to) %text%]

Proposed change:
ban %texts/offline players% [(by reason of|because [of]|on account of|due to) %text%] [for %timespan%]

@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Dec 2, 2019
@Jayderp
Copy link
Author

Jayderp commented Dec 2, 2019

In my opinion, rather than adding a new effect, I would like to see an optional time span added to the current ban effect.

ex:
Current ban effect:
ban %texts/offline players% [(by reason of|because [of]|on account of|due to) %text%]

Proposed change:
ban %texts/offline players% [(by reason of|because [of]|on account of|due to) %text%] [for %timespan%]

good idea

@Zulfen
Copy link

Zulfen commented Dec 4, 2019

yeah sounds good

@Jayderp Jayderp mentioned this issue Dec 14, 2019
Closed
@Whimsyturtle Whimsyturtle added priority: low Issues that are not harmful to the experience but are related to useful changes or additions. and removed priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Dec 17, 2019
@ShaneBeee ShaneBeee mentioned this issue Jan 3, 2020
Merged
bensku pushed a commit that referenced this issue Jan 11, 2020
@ShaneBeee @bensku
Add support for temp bans (#2667)
433aeab 
* EffBan - add an optional time span to temp ban a player

* EffBan - Prevent null from timespan

* Revert "EffBan - Prevent null from timespan"

This reverts commit 13f94e6

* EffBan - Prevent null from timespan

* EffBan - prevent perma banning if timespan = null

* EffBan - removed error message, revert back to perm ban if timespan = null, updated description to let users know of this
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 11, 2020
@bensku bensku closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bensku @Whimsyturtle @ShaneBeee @Zulfen @Jayderp