Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on experience spawn event #2751

Closed
vhone opened this issue Jan 11, 2020 · 1 comment · Fixed by #2811
Closed

on experience spawn event #2751

vhone opened this issue Jan 11, 2020 · 1 comment · Fixed by #2811
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@vhone
Copy link

vhone commented Jan 11, 2020 •
edited
Loading

Description

Each time you reload skript with the reload command, the on experience spawn event is stacked.

Steps to Reproduce

on experience spawn:

> broadcast "Spawn~"

I reloaded five times and the message is printed five times when the event occurs. The more you reload, the more messages you get at once.

Expected Behavior

Errors / Screenshots

https://drive.google.com/file/d/1nFUO576lBWkoYDIbjH6-DyZPcJlE9mG6/view?usp=sharing

Server Information

  • Server version/platform: paper 1.15.1 build 31
  • Skript version: v2.4.1

Additional Context
@bensku bensku added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Jan 11, 2020
@Whimsyturtle
Copy link
Member

Whimsyturtle commented Jan 12, 2020 •
edited
Loading

I can confirm this issue. Seems very weird... and potentially dangerous if other events are also affected.

@Whimsyturtle Whimsyturtle added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). and removed needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. labels Jan 12, 2020
@ShaneBeee ShaneBeee mentioned this issue Feb 9, 2020
Merged
@ShaneBeee ShaneBeee linked a pull request Feb 9, 2020 that will close this issue
Fix EvtExperienceSpawn firing more than once #2811
Merged
bensku added a commit that referenced this issue Feb 29, 2020
@ShaneBeee @bensku
Fix EvtExperienceSpawn firing more than once (#2751)
f0100a7 
* EvtExperienceSpawn - fix event firing more than once

* EvtExperienceSpawn - fix line endings

Co-authored-by: bensku <bmi@iki.fi>
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix EvtExperienceSpawn firing more than once
3 participants
@bensku @Whimsyturtle @vhone