Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function is deleted while it isn't #2802

Closed
iOshawott opened this issue Jan 31, 2020 · 6 comments
Closed

Function is deleted while it isn't #2802

iOshawott opened this issue Jan 31, 2020 · 6 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Comments

@iOshawott
Copy link

Description

While reloading my skript it randomly appears something like this
https://oshawott.pl/ss/205b.png ( "The function 'money' was deleted or renamed (...)" )
but I haven't changed anything and the function is on it's place all the time. My friend said that he see it too

Steps to Reproduce

Can't provide how to reproduce, sorry. I tried to do a code for it, but it failed. Maybe it depends on time (I tried only with short time)

Expected Behavior

It shouldn't appear that a function is removed or renamed : d

Errors / Screenshots

^like I said + no more errors

Server Information

  • Server version/platform: Paper-84 1.15.2
  • Skript version: 2.5-alpha1

Additional Context
@ShaneBeee
Copy link
Contributor

This usually happens when reloading scripts, especially if the function was moved.

@iOshawott
Copy link
Author

iOshawott commented Feb 1, 2020 •
edited
Loading

This usually happens when reloading scripts, especially if the function was moved.

It would be understandable, but the function stays at same place all the time (and throws a lot of errors on reload...)
We don't touch it (function), just editing code in skript with function makes this happen o.O

@TPGamesNL
Copy link
Member

I usually get this error when I use a function in an effect command (on 2.4.1)

@short509
Copy link

short509 commented Feb 2, 2020 •
edited
Loading

me too, please fix reload function error.

@jaylawl
Copy link
Contributor

jaylawl commented Feb 18, 2020

same, occuring very often, especially when re-loading specific script files only

@iOshawott iOshawott mentioned this issue Feb 18, 2020
Closed
@bensku bensku added needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. and removed needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. labels Feb 29, 2020
@bensku bensku mentioned this issue Feb 29, 2020
Merged
@ShaneBeee
Copy link
Contributor

Fixed in 2.5-alpha2

bensku added a commit that referenced this issue Mar 26, 2020
@bensku @ShaneBeee
Fix function reloading (#2802)
7387993 
* Add script reload API. Centralize function clearing to unloadScript_()

* Use new reload API for Skript's own reloading needs

* Fix function unloading I just broke

Co-authored-by: Shane Bee <shanebolenback@me.com>
@TheLimeGlass TheLimeGlass mentioned this issue Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bensku @jaylawl @ShaneBeee @short509 @TPGamesNL @iOshawott