Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweeping Edge uses wrong enchantment name ("enchantments.names.sweeping") #401

Closed
TheBentoBox opened this issue Feb 25, 2017 · 2 comments
Closed
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@TheBentoBox
Copy link
Member

TheBentoBox commented Feb 25, 2017

Hello

Attempting to enchant a tool with the 1.11.2 "Sweeping Edge" enchantment does not work as expected. The attempted fix was made in this commit, but this change wasn't sufficient, as it requires you to use "enchantments.names.sweeping" instead of the expected "sweeping edge" to reference the enchantment.

Example Tests

image
As you can see, the final test worked fine, using enchantments.names.sweeping.
This issue is also visible when looking at the Enchantment type on the types documentation, where the enchantment is listed as enchantments.names.sweeping.

Setups

  • Skript dev24b
  • Recent Spigot 1.11.2 build

How To Fix

Apparently, the issue is that the lang file was updated to use sweeping_edge as the enchantment ID while it should be just sweeping. I personally haven't tested this, but Ayase/Snow-Pyon of the Skript forums has tested for me and confirmed it worked on their server by manually editing the english.lang file to say sweeping: Sweeping Edge instead. I'm not sure why this would be the case, as the Spigot Enchantment enum uses the wording you used originally (SWEEPING_EDGE), however, the vanilla enchantment name is just sweeping, which may be causing the issue. I don't know how Skript's enchantment parsing works.

@TheBentoBox TheBentoBox added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 25, 2017
bensku added a commit that referenced this issue Mar 3, 2017
@bensku bensku closed this as completed Mar 4, 2017
@bloggy
Copy link

bloggy commented Dec 25, 2017

For me this does not work. What is the correct name to use?
I tried everything:

set {_enchantment} to "Sweeping Edge"
enchant {_item} with "%{_enchantment}% 1"

Tried: Sweeping, Sweeping Edge, sweeping_edge

Nothing works

@bensku
Copy link
Member

bensku commented Jan 5, 2018

Implicit string to enchantment conversion does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

3 participants