Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'&k &l &m &o' not reset after other color code #542

Closed
marcellmit2l opened this issue May 2, 2017 · 6 comments
Closed

'&k &l &m &o' not reset after other color code #542

marcellmit2l opened this issue May 2, 2017 · 6 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@marcellmit2l
Copy link

Hello, I have found that the formatting code &k &l &m &o after a color code not be reset.

You should use &r to reset. > &a&nHello &r&9this is blue
It's not too bad, but I wanted to say it.

send "&a&oTest1 &5&b&nTest2 &cTest3 &dTest4 &e&lTest5 &f&mTest6"

@Syst3ms
Copy link
Contributor

Syst3ms commented May 2, 2017

I think this is intended behaviour

@TheBentoBox
Copy link
Member

TheBentoBox commented May 2, 2017

This really should not be the intended behavior, though. No other plugin in the history of ever has sent messages this way. If you set a region entry/exit in WorldGuard, color codes reset these markup codes. If you set up messages in Essentials (such as join messages, or using its books), color codes again will not work like this.

I honestly can't say I understand the mentality behind this. Color codes should work exactly as Bukkit and Minecraft intends them to, which is with color codes resetting other codes. Even weirder is that specifying "colored" for messages in the dev26 releases fixes many of the issues because it forces Skript to run the Bukkit colorizer on the message, making it work as intended, but we shouldn't really have to do that to get it to work like it should, especially since we never had to before and since this change causes unintended changes to literally every script ever written that sends any formatted messages. It's completely backwards incompatible, and without the tradeoff of being for the greater good since it's also unintuitive with how sending messages works in both vanilla Minecraft and with any other plugin.

That's my two cents, at least.

@bensku
Copy link
Member

bensku commented May 3, 2017

If chat codes (legacy ones) worked as Minecraft handles them with JSON chat, they would not work at all. Sure, I can do that too... but it is probably what you want.

Probably I'll just make toggleable hack for this, though I'm not sure how exactly that'd work.

Edit: For reference, JSON chat format

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label May 3, 2017
@TheLimeGlass
Copy link
Collaborator

Closed? Also I like the older methods or i'm just used to it after all these years.

@bensku bensku closed this as completed May 10, 2017
@andrewjunggg
Copy link

The new enhancement makes i have to change all of my tons of skripts.
It will reset the color every variable set up, it's very annoying.
I hope you change it back to the older methods.

@bensku
Copy link
Member

bensku commented May 25, 2017

This has nothing to do with color codes reseting formatting (which they now, by default, do). What you're describing is a bug, which might be surprisingly hard to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

6 participants