Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links & JSON Chat Bug #620

Closed
TheClassic36 opened this issue Jun 2, 2017 · 11 comments
Closed

Links & JSON Chat Bug #620

TheClassic36 opened this issue Jun 2, 2017 · 11 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@TheClassic36
Copy link

TheClassic36 commented Jun 2, 2017

I don't know how to explain this...

#Links:
	Meme: <link:goo.gl/X6Nok5>Click here
#Messages:
        MemeMessage: for the meme.
#Chat:
       send "{@Prefix} {@Meme} &f{@MemeMessage}

Clicking the "here" in the chat doesn't actually take the user to the link but to https://here with lenient link parsing. (dev28c & dev29)

@bensku
Copy link
Member

bensku commented Jun 2, 2017

Do you have lenient link parsing enabled... ? You might want to toggle it off until I manage to fix it.

@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 2, 2017
@TheClassic36
Copy link
Author

Yeah, I have it enabled. Thanks :)

@Legoman99573
Copy link
Contributor

Mojang changed how chat works, so yeah, chat plugins will break.

@TheClassic36
Copy link
Author

I assume that they changed it due to the Narrator?

@bensku
Copy link
Member

bensku commented Jun 4, 2017

Umm no. Chat protocol did not change significantly with 1.12. Mostly localization related stuff.

@DoreK333
Copy link

When will the error be fixed?
Players complain that clicking on a link does not open the page.

@TheClassic36
Copy link
Author

Yeah... That seems to be a result of this bug. Hopefully, it will be fixed soon.

@DoreK333
Copy link

DoreK333 commented Jun 18, 2017

I have a solution to this problem!
Set it up in a configuration and it will work!

parse links in chat messages: strict
# Controls how Skript will try to parse links in chat messages.
# If 'disabled' or 'false', no links will be automatically parsed.
# When 'strict', everything starting with http(s):// will be parsed as link.
# When 'lenient', everything that contains a dot will be interpreted as a link.

@TheClassic36
Copy link
Author

TheClassic36 commented Jun 18, 2017

Lenient link parsing is the problem here, so that isn't really a solution.

@YellowZaki
Copy link

I confirm this

@bensku
Copy link
Member

bensku commented Jun 24, 2017

Lenient link parser did not correctly verify validity of a link, so everything that had a dot would be parsed as a link. Fixed this for next release.

bensku added a commit that referenced this issue Jun 24, 2017
@bensku bensku closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

5 participants