Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleporting ignores yaw + pitch? #996

Closed
StealWonders opened this issue Dec 2, 2017 · 21 comments · Fixed by #3123
Closed

Teleporting ignores yaw + pitch? #996

StealWonders opened this issue Dec 2, 2017 · 21 comments · Fixed by #3123
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Milestone

Comments

@StealWonders
Copy link

I have locations saved into variables which used to teleport players to the location I set (with north south location respected) Now in dev32b it just teleports player looking at the north with is rather annoying... Having to turn around every time when you spawn (get teleported) is just plain stupid.

@bensku
Copy link
Member

bensku commented Dec 4, 2017

What version were you using before?

@StealWonders
Copy link
Author

2.2-dev29

@bensku
Copy link
Member

bensku commented Dec 4, 2017

Oh. That is weird... Same server version, right?

@StealWonders
Copy link
Author

I'm not sure - I might have updated to 1.12.2

@TheBentoBox
Copy link
Member

Can anyone else reproduce this with dev32 on 1.12.2?

@Pikachu920
Copy link
Member

Pikachu920 commented Jan 12, 2018

i can reproduce it, although its on 1.8:

also confirmed on 1.12:

@GrimEpp
Copy link

GrimEpp commented Jan 12, 2018

This is not an error on the latest build of Skript 1.12.2 or a bug

@Pikachu920
Copy link
Member

@GrimEpp can you provide a screenshot? i reproduced it on dev32d.

@jaylawl
Copy link
Contributor

jaylawl commented Jan 25, 2018

having this issue also. generally setting the yaw of an entity doesn't work for me, but won't throw any bugs either. for instance:

set victim's yaw to attacker's yaw

nothing

@Snow-Pyon
Copy link

@jaylawl that's a expected behaviour, as you have to teleport the entity to actually change it.

@TheBentoBox
Copy link
Member

If setting the yaw/pitch of an entity isn't supposed to work then it should be changed so that setters for it don't parse. It should be disallowed & give a warning saying to use teleportation instead. Unless I'm misunderstanding something.

@Snow-Pyon
Copy link

Or, I could make it so when you set the yaw/pitch of an entity it also teleports the entity, either way works.

@TheBentoBox
Copy link
Member

That works too!

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 29, 2018
@Pikachu920
Copy link
Member

shouldn't this be bug not enhancement? this used to work

@Pikachu920 Pikachu920 added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels May 25, 2018
@Blueyescat
Copy link
Contributor

Blueyescat commented Oct 10, 2018

Weird, but this happens only when the yaw or pitch is 0, 90, 180, 270 or 360. For example 360.01 will work and it will be 360 in the game.

Related to https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/effects/EffTeleport.java#L105

@Whimsyturtle Whimsyturtle added the priority: low Issues that are not harmful to the experience but are related to useful changes or additions. label Dec 17, 2019
@Whimsyturtle
Copy link
Member

Adding priority for this issue since it still occurs on Skript 2.4 / Spigot 1.14.4 2 years after the issue was made...

@bluelhf
Copy link
Contributor

bluelhf commented Dec 17, 2019

According to my testing, even using values like 0.00001 will work, but not 0.

@Whimsyturtle
Copy link
Member

@bluelhf
Copy link
Contributor

bluelhf commented Dec 17, 2019

Could maybe make the effect something like teleport %entities% (to|%direction%) %location% [directionally], ignore direction unless directionally is present?

@StealWonders
Copy link
Author

It's 2020 now and still not fixed. :-(

@APickledWalrus
Copy link
Member

I’ll open a PR soon to fix this issue.

@FranKusmiruk FranKusmiruk added this to the 2.5 milestone Jul 10, 2020
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.