Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #43, add alphabetically sorting of strings #128

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Fix #43, add alphabetically sorting of strings #128

merged 1 commit into from
Jul 15, 2016

Conversation

28andrew
Copy link
Contributor

Fix #43, add alphabetically sorting of strings.

@bensku bensku merged commit fa513a2 into SkriptLang:master Jul 15, 2016
@bensku
Copy link
Member

bensku commented Jul 15, 2016

I will need to change few things, but good work.

  • Docs formatting
  • Not @author in docs
  • init method first, as in other expressions?

I'll need to create style guidelines soon...

Edit: Really, PLEASE use Eclipse and DO NOT change null annotation settings. Skript does little argument checking runtime, and I do not want random NullPointerExceptions everywhere.

And more generic Java guidelines should be followed, too... Do not declare type as ArrayList. And use existing API if possible, like Arrays.sort() method...

@28andrew
Copy link
Contributor Author

28andrew commented Jul 15, 2016

PLEASE use Eclipse and DO NOT change null annotation settings.

I use Eclipse, its just that I couldn't get errors to go away with null pointer exception checking on. I didn't realize there was an Arrays.sort() method either. I'll try to follow the "guidelines" you just taught me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants