FoxData - fixes #2536
Merged
FoxData - fixes #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed an issue with "all foxes" not doing anything
TheBentoBox
added
bug
|
Oops, meant to add those to the related issue. Though this does make me wonder if we should tag PRs sometimes! |
- Added tests to check for deletion of all foxes
Whimsyturtle
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue with "all foxes" returning nothing.
Currently
all foxeswill have no result in anything, ex:neither of these work. Doing the same with
all red foxesorall snow foxesworks, but trying to deal with both at once will not.I also removed the simple entity data for foxes, I originally put that in before Snow created the FoxData class. This line is no longer needed.
Target Minecraft Versions: 1.14+
Requirements: 1.14+
Related Issues: #2535