Fix default block data applying to all placed blocks #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneBeee
added
the
bug
Pikachu920
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So one issue is settings blocks will always default to Bukkit's default block data.
The issue here is blocks such as fences, it will set a single fence post, and will not connect to blocks next to it. The reason this happens is because Skript sets the default block data.
This PR fixes it by not setting block data if no block data is determined (ie: using an aliases with no option block data properties)
If an alias which is not default is used, then the Block data of said alias will be applied to the set block.
Target Minecraft Versions: 1.13+
Requirements: none
Related Issues: #2292