-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make event parsing more reliable #5900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
added
the
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
label
Aug 10, 2023
TheLimeGlass
requested changes
Aug 10, 2023
sovdeeth
approved these changes
Aug 10, 2023
Moderocky
approved these changes
Aug 10, 2023
TheLimeGlass
added
the
breaking changes
Pull or feature requests that contain breaking changes (API, syntax, etc.)
label
Aug 11, 2023
bluelhf
approved these changes
Aug 11, 2023
AyhamAl-Ali
approved these changes
Aug 24, 2023
TheLimeGlass
previously requested changes
Aug 27, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
September 16, 2023 16:59
bd134d0
to
3f08853
Compare
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Moderocky
reviewed
Sep 22, 2023
Pikachu920
reviewed
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely pr thank you tud
Pikachu920
approved these changes
Nov 11, 2023
sovdeeth
approved these changes
Nov 12, 2023
Fusezion
approved these changes
Nov 12, 2023
sovdeeth
added
2.8
Targeting a 2.8.X version release
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
labels
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.8
Targeting a 2.8.X version release
breaking changes
Pull or feature requests that contain breaking changes (API, syntax, etc.)
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes event parsing more reliable by using a similar parsing strategy to if statements, by separating data related to the event and the actual syntax of the event so we could add data to the event pattern more easily in the future. The new event syntax will be
[on] <.+> [with priority (:(lowest|low|normal|high|highest|monitor))]
where<.+>
is the actual syntax of the event inputted by the user (without any modifications)Target Minecraft Versions: any
Requirements: none
Related Issues: none