Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Breakable Syntax to Existing Unbreakable Syntaxes #6160

Merged
merged 12 commits into from
May 8, 2024
Merged

Add Breakable Syntax to Existing Unbreakable Syntaxes #6160

merged 12 commits into from
May 8, 2024

Conversation

NotSoDelayed
Copy link
Contributor

Description

This PR adds breakable syntax to the existing unbreakable syntaxes to Skript, and cleans up the involved classes.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Moderocky
Moderocky requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for ExprUnbreakable to make sure it works? :)

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 1, 2023
sovdeeth
sovdeeth approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

src/main/java/ch/njol/skript/conditions/CondIsUnbreakable.java Outdated Show resolved Hide resolved
@sovdeeth sovdeeth added the 2.8 Targeting a 2.8.X version release label Dec 30, 2023
@sovdeeth sovdeeth added 2.9 Targeting a 2.9.X version release and removed 2.8 Targeting a 2.8.X version release labels Mar 21, 2024
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Apr 15, 2024
@sovdeeth sovdeeth merged commit fd833ac into SkriptLang:dev/feature May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NotSoDelayed @sovdeeth @Moderocky @APickledWalrus