Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Potion Effect Event #6532

Merged

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Apr 3, 2024

Description

Adds the Entity Potion Effect event, inspired by SkBee's syntax of the same event.
Adds the %past event-potioneffect%, %event-potioneffect% and %event-potioneffecttype% event-values for this event.

Original Issue: #5774

Note: I have no clue why some of the imports went to .*, sorry about that.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Apr 4, 2024
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

@Asleeepp Asleeepp requested a review from sovdeeth April 19, 2024 02:30
@sovdeeth sovdeeth changed the base branch from master to dev/feature April 19, 2024 22:49
@sovdeeth
Copy link
Member

Build failures due to upstream paper change, will be fixed when patch is merged into feature

@Asleeepp
Copy link
Contributor Author

Asleeepp commented Apr 19, 2024

Build failures due to upstream paper change, will be fixed when patch is merged into feature

oh okay, was losing my mind wondering what was wrong lmao

src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated Show resolved Hide resolved
src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
src/main/resources/lang/default.lang Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth April 20, 2024 18:17
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems alright to me off the top of my head

src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from AyhamAl-Ali April 20, 2024 20:21
@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Jun 29, 2024
@Asleeepp Asleeepp requested a review from UnderscoreTud July 1, 2024 22:48
@APickledWalrus APickledWalrus removed the 2.9 Targeting a 2.9.X version release label Jul 2, 2024
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 17, 2024
@sovdeeth sovdeeth merged commit c4c5560 into SkriptLang:dev/feature Sep 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants