Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connected pattern paper-only. #6573

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Moderocky
Copy link
Member

Description

Shane noticed that isConnected is only a Paper method, so that pattern now registers only if the method exists.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Moderocky Moderocky changed the base branch from master to dev/feature April 15, 2024 15:43
@ShaneBeee
Copy link
Contributor

Only suggestion I'd have here is make a note in the docs that connected requires PaperMC 1.20+
(I can't find the exact version but I see it doesn't appear in the 1.19 Javadocs)

@sovdeeth sovdeeth merged commit b6463c7 into SkriptLang:dev/feature Apr 15, 2024
4 checks passed
@Moderocky Moderocky deleted the fix-is-connected branch April 15, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants