-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tooltip syntax #6712
Merged
Merged
Adds tooltip syntax #6712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
suggested changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting changes I could see
APickledWalrus
requested changes
May 19, 2024
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com> Co-authored-by: Fusezion <fusezionstream@gmail.com>
- Changed the parse marks/tags in the effect and patterns for the condition - Added some info to the condition's description
sovdeeth
requested changes
May 29, 2024
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
- Changed the condition to use setNegated and isNegated, and use Sovde's pattern changes - Changed the effect description and fixed to work with Sovde's pattern changes
TheLimeGlass
previously requested changes
Jun 16, 2024
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
APickledWalrus
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have some recommendations but no issues
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
sovdeeth
approved these changes
Jun 28, 2024
sovdeeth
added
2.9
Targeting a 2.9.X version release
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
labels
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.9
Targeting a 2.9.X version release
feature
Pull request adding a new feature.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an effect, condition, and test for tooltip-related syntax.
Target Minecraft Versions: 1.20.5+
Requirements: MC 1.20.5+
Related Issues: