Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tooltip syntax #6712

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Adds tooltip syntax #6712

merged 16 commits into from
Jul 1, 2024

Conversation

cheeezburga
Copy link
Member

Description

Adds an effect, condition, and test for tooltip-related syntax.


Target Minecraft Versions: 1.20.5+
Requirements: MC 1.20.5+
Related Issues:

@APickledWalrus APickledWalrus added the feature Pull request adding a new feature. label May 19, 2024
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting changes I could see

src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
cheeezburga and others added 2 commits May 21, 2024 01:20
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Co-authored-by: Fusezion <fusezionstream@gmail.com>
- Changed the parse marks/tags in the effect and patterns for the condition
- Added some info to the condition's description
Moderocky and others added 4 commits June 1, 2024 07:57
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
- Changed the condition to use setNegated and isNegated, and use Sovde's pattern changes
- Changed the effect description and fixed to work with Sovde's pattern changes
@cheeezburga cheeezburga requested a review from sovdeeth June 1, 2024 09:52
src/main/java/ch/njol/skript/conditions/CondTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffTooltip.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/conditions/CondTooltip.sk Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/conditions/CondTooltip.sk Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/conditions/CondTooltip.sk Outdated Show resolved Hide resolved
cheeezburga and others added 2 commits June 16, 2024 15:16
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@cheeezburga cheeezburga requested a review from TheLimeGlass June 16, 2024 05:20
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have some recommendations but no issues

@sovdeeth sovdeeth added 2.9 Targeting a 2.9.X version release feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jul 1, 2024
@sovdeeth sovdeeth merged commit 3c0119f into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants