Fix ExprArithmetic Set Construction #6758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
UnderscoreTud
approved these changes
Jun 3, 2024
Moderocky
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix two issues with ExprArithmetic introduced in #6624.
Since the PR was merged into 2.8 instead of 2.9, the
Set#ofcase was not safe since it requires Java 9. Additionally,Set#ofthrows an error in some cases of Vector arithmetic (multiplication) when thereturnTypeslist may contain duplicate values.Target Minecraft Versions: any
Requirements: none
Related Issues: This was reported in Discord. The fix was confirmed to be working for the affected user.