Add underscore formatting in numbers

[Efnilite]

Description

Resolves #7015. Adds underscore support for formatting in numbers.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #7015

[Fusezion]

I don't believe we need a regression test currently but an actual test added, this isn't so much resolving a bug as much as adding an enhancement to numbers.

[Efnilite]

I don't believe we need a regression test currently but an actual test added, this isn't so much resolving a bug as much as adding an enhancement to numbers.

Should I put it in the misc folder then?

[Fusezion]

Yeah I think misc is fair as this isn't syntax related

[Asleeepp]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like ____1___ shouldn't be valid

heres the discord conversation if you're curious: here

[UnderscoreTud]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like _1 shouldn't be valid

heres the discord conversation if you're curious: here

That already isn't valid, but my main concern is how you can have adjacent underscores, for example 1___0 is valid when I don't think it makes that much sense.

[Efnilite]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like _1 shouldn't be valid

heres the discord conversation if you're curious: here

This has already been addressed in the last lines of the test. Parsing the numbers starting and/or ending with _ seems to resolve to none, as these numbers don't match the updated regex. If anything else should be changed, please lmk

[Efnilite]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like _1 shouldn't be valid
heres the discord conversation if you're curious: here

That already isn't valid, but my main concern is how you can have adjacent underscores, for example 1___0 is valid when I don't think it makes that much sense.

Personally I agree that having multiple _ is a little silly but someone might have a genuine use case for it, like maybe someone prefers 1__000__000 over 1_000_000. Java also support this.

I don't think this reason should axe this entire PR. It would be possible to limit it to just one _ if more people think it's a good idea.

[Asleeepp]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like _1 shouldn't be valid
heres the discord conversation if you're curious: here

That already isn't valid, but my main concern is how you can have adjacent underscores, for example 1___0 is valid when I don't think it makes that much sense.

Personally I agree that having multiple _ is a little silly but someone might have a genuine use case for it, like maybe someone prefers 1__000__000 over 1_000_000. Java also support this.

I don't think this reason should axe this entire PR. It would be possible to limit it to just one _ if more people think it's a good idea.

then i think that it would be better to make it consistent across the whole number
someone cant do 1__000_000 for example
though maybe there should also be a limit on how many underscores you can use

[UnderscoreTud]

Kenzie mentioned something about adding a way to detect if it was a valid number, something like _1 shouldn't be valid
heres the discord conversation if you're curious: here

That already isn't valid, but my main concern is how you can have adjacent underscores, for example 1___0 is valid when I don't think it makes that much sense.

Personally I agree that having multiple _ is a little silly but someone might have a genuine use case for it, like maybe someone prefers 1__000__000 over 1_000_000. Java also support this.

I don't think this reason should axe this entire PR. It would be possible to limit it to just one _ if more people think it's a good idea.

@APickledWalrus and I talked about it on discord and he also thought the same thing (that it shouldn't be allowed), but we can wait and see what the other members think

[sovdeeth]

oh yes i definitely don't think it you should axe this pr
but i do agree that only 1 underscore makes sense and should be the requirement

[Efnilite]

Aight, changed it to at most one and added tests for making sure that having multiple isn't supported

[Asleeepp]

since you requested my review (my approval does nothing haha)