Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Click BlockData #7130

Merged
merged 13 commits into from
Oct 31, 2024

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to support blockdata for on click


Target Minecraft Versions: any
Requirements: none
Related Issues: #6305

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small stuff, but you should also remove finals that are scattered throughout, and theres still code that can be updated (switch statements, etc.).

src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
@cheeezburga cheeezburga added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 5, 2024
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with @cheeezburga's changes

src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
@TheAbsolutionism
Copy link
Contributor Author

Just some small stuff, but you should also remove finals that are scattered throughout, and theres still code that can be updated (switch statements, etc.).

I could change to an enhanced switch, but I cant put both case PHYSICAL and default on the same line leading to two return falses
Other than that, I dont really see anything else sticking out that might need to be updated, imo, but if you would like to point out some things I can take a look.

src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
@cheeezburga
Copy link
Member

I could change to an enhanced switch, but I cant put both case PHYSICAL and default on the same line leading to two return falses Other than that, I dont really see anything else sticking out that might need to be updated, imo, but if you would like to point out some things I can take a look.

I think an enhanced one would look a bit nicer, but up to you. I don't think there was anything else, but I wouldn't hate if you wanted to change the error messages a bit in init, as they seem a bit clunky and/or misleading at the moment.

src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtClick.java Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sovdeeth sovdeeth requested a review from Moderocky October 26, 2024 14:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sovdeeth sovdeeth merged commit b60d8ed into SkriptLang:dev/feature Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants