-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Click BlockData #7130
On Click BlockData #7130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small stuff, but you should also remove final
s that are scattered throughout, and theres still code that can be updated (switch statements, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with @cheeezburga's changes
I could change to an enhanced switch, but I cant put both |
I think an enhanced one would look a bit nicer, but up to you. I don't think there was anything else, but I wouldn't hate if you wanted to change the error messages a bit in |
Description
This PR aims to support blockdata for on click
Target Minecraft Versions: any
Requirements: none
Related Issues: #6305