Prevent long overflow in arithemetic #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses Math.xExact code to catch overflows instead of relying on doubles.
sovdeeth
added
bug
Efnilite
approved these changes
Nov 10, 2024
src/main/java/ch/njol/skript/classes/data/DefaultOperations.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/DefaultOperations.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Moderocky
approved these changes
Nov 12, 2024
Moderocky
added
the
patch-ready
APickledWalrus
approved these changes
Nov 21, 2024
UnderscoreTud
approved these changes
Nov 21, 2024
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Dec 3, 2024
* catch long overflows * don't compromise with precision uses Math.xExact code to catch overflows instead of relying on doubles. * Apply suggestions from code review Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> --------- Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catches long overflows in arithmetic by taking code from Math.addExact and multiplyExact to detect if an overflow occurred.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7209