-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait Until #7288
base: dev/feature
Are you sure you want to change the base?
Wait Until #7288
Conversation
I'm not sure I like hiding the mechanics from the user in this case. It doesn't seem like a significant improvement over
(it also seems ripe for causing a lot of hidden background while loops that will spin forever) |
Even with idea64_f6cdRAxzPA.mp4 |
Of course, but it's very clear that it's a while loop. It's not disguised. |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me likes this, though I do share some of the concerns presented by sovde. Additionally, in its current state, this leads to repeat expression evaluation (ex: for the timespan) which is not ideal. We'd probably want to make this more efficient by avoiding that and using a repeated task.
Description
This PR aims to allow using EffDelay to wait until condition is met.
Test Proof
https://github.com/user-attachments/assets/1d5f6d62-6690-4f47-9a4e-a3774a39564a
Target Minecraft Versions: any
Requirements: none
Related Issues: #5768