Removes no-keyword pattern from ExprNewBannerPattern #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
APickledWalrus
approved these changes
Jan 29, 2025
Fusezion
approved these changes
Jan 29, 2025
It was decided not to attempt to reimplement the pattern as no safe and reasonable pattern was found.
cheeezburga
approved these changes
Jan 29, 2025
Moderocky
approved these changes
Jan 29, 2025
Efnilite
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pattern was responsible for significant slowdown in parsing due to its lack of required keywords.
Removing this pattern caused one test case of 3000 structures to go from a 4 minute parse time to a 1 minute parse time.
Target Minecraft Versions: any
Requirements: none
Related Issues: none