Skip to content

SkriptJUnitTest#spawnTestEntity + Cleanup #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sovdeeth merged 11 commits into from
Jun 3, 2025
Merged

SkriptJUnitTest#spawnTestEntity + Cleanup #7791

sovdeeth merged 11 commits into from
Jun 3, 2025

Conversation

@Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Apr 10, 2025 •
edited
Loading

Description

This PR aims to add a #spawnTestEntity method allowing for easier spawning of entities for JUnit tests, and cleans up some of the JUnit tests.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested review from a team as code owners April 10, 2025 06:03
@Absolutionism Absolutionism requested review from UnderscoreTud and sovdeeth and removed request for a team April 10, 2025 06:03
Efnilite
Efnilite requested changes Apr 10, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from Efnilite April 10, 2025 20:19
sovdeeth
sovdeeth requested changes Apr 11, 2025
View reviewed changes
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Apr 11, 2025
@Absolutionism Absolutionism changed the title Additional SkriptJUnitTest Methods SkriptJUnitTest#spawnEntity + Cleanup Apr 21, 2025
@Absolutionism Absolutionism requested a review from sovdeeth April 21, 2025 03:35
@Absolutionism Absolutionism changed the title SkriptJUnitTest#spawnEntity + Cleanup SkriptJUnitTest#spawnTestEntity + Cleanup Apr 21, 2025
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 25, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch April 25, 2025 02:22
@sovdeeth sovdeeth force-pushed the dev/AdditionalJUnitMethods branch from ea6d77f to 42f0a5e Compare April 25, 2025 02:30
@sovdeeth sovdeeth changed the base branch from dev/patch to dev/feature April 25, 2025 02:30
@APickledWalrus APickledWalrus added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Apr 30, 2025
APickledWalrus
APickledWalrus approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@APickledWalrus APickledWalrus added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels May 1, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Releases May 14, 2025
@sovdeeth sovdeeth merged commit b69e6be into SkriptLang:dev/feature Jun 3, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jun 3, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@Absolutionism @erenkarakal
SkriptJUnitTest#spawnTestEntity + Cleanup (SkriptLang#7791)
68e77ed 
* Initial Commit

* Update PlayerElytraBoostEventTest.java

* Requested Changes

* Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-maintainers

Assignees

No one assigned

Labels

feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

No open projects
2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Absolutionism @sovdeeth @APickledWalrus @Efnilite