Make CondIsEnchanted look for exact enchants by default, with optional greater/equal to. #7816
+170
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
sovdeeth
requested review from
Pikachu920 and
erenkarakal
and removed request for
a team
sovdeeth
changed the title
Efnilite
approved these changes
Apr 29, 2025
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
approved these changes
May 20, 2025
erenkarakal
added
feature-ready
APickledWalrus
requested changes
Jun 4, 2025
1 task
sovdeeth
removed
the
feature-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
added
the
feature-ready
skriptlang-automation
bot
added
the
completed
skriptlang-automation
bot
removed
the
feature-ready
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
…l greater/equal to. (SkriptLang#7816) * Make exact the default and greater than the opt-in * allow greater than and lesser than or equal to * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current behavior means
if {_x} is enchanted with sharpness 2succeeds if {_x} has sharpness 5. This is a bit unintuitive imo, so this PR changes the default so that no longer succeeds. Only sharpness 2 would count.is enchanted with sharpnessstill matches all levels. To have the old behavior, you now useis enchanted with sharpness 2 or better.It's a breaking change, but a beneficial one in my opinion.
Also fixes a double-evaluation bug with the condition.
Target Minecraft Versions: any
Requirements: none
Related Issues: #4517