Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the function event on Function#execute and pass the Function onto the event #816

Merged
merged 4 commits into from
Sep 1, 2017
Merged

Conversation

28andrew
Copy link
Contributor

Related issues: Adds enhancement #610

Description:
On Function#execute it will now call the event and pass the function on to it.

Copy link
Member

@bensku bensku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make use of generics in all places where you handle Function instances. Also please remove setFunction or make it package-private as setting function to event after calling it could cause numerous problems.

@bensku bensku merged commit 693ae45 into SkriptLang:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants