Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c++11 building support #100

Merged
merged 6 commits into from
Aug 12, 2022
Merged

c++11 building support #100

merged 6 commits into from
Aug 12, 2022

Conversation

wbpcode
Copy link
Contributor

@wbpcode wbpcode commented Aug 11, 2022 •
edited
Loading

Signed-off-by: wangbaiping wbphub@live.com

std::make_unique (from c++14) -> absl::make_unique
std::string_view (from c++17) -> absl::string_view
std::optional (from c++17) -> absl::optional
std::nullopt (from c++17) -> absl::nullopt

absl::string_view/absl::optional/absl::nullopt/... will be alias of std::string_view/std::optional/std::nullopt/... after c++17 by default. So it's ok to always use the absl::* in c++11/c++14/c++17 versions.

@wbpcode
c++11 building support
a80b3bf 
Signed-off-by: wangbaiping <wbphub@live.com>
@wbpcode wbpcode assigned wbpcode and wu-sheng and unassigned wbpcode Aug 11, 2022
@wu-sheng
Copy link
Member

So, we will have c++11 and c++17 in support at the same time?

@wu-sheng wu-sheng added this to the 0.5.0 milestone Aug 11, 2022
@wbpcode
Copy link
Contributor Author

wbpcode commented Aug 11, 2022

So, we will have c++11 and c++17 in support at the same time?

yep.

@wu-sheng
Copy link
Member

Could you add a CI for C++11 build and update the doc to mention 11 and 17 supported?

@wbpcode
Copy link
Contributor Author

wbpcode commented Aug 11, 2022

In fact it's build by c++11 by default for now because I remove the explicit option of --cxxopt=-std:c++17. But it's OK for me to add a new test for it.

@wbpcode
Copy link
Contributor Author

wbpcode commented Aug 11, 2022

/wait

@wbpcode
Copy link
Contributor Author

wbpcode commented Aug 11, 2022

some warnings need to be resolved.

wu-sheng and others added 5 commits August 11, 2022 22:10
@wu-sheng
Merge branch 'main' into dev-cpp-11
1293232
@wbpcode
add ci & add -Werror & resolved all warning
6c184da 
Signed-off-by: wangbaiping <wbphub@live.com>
@wbpcode
Merge branch 'dev-cpp-11' of https://github.com/wbpcode/cpp2sky into …
3d6725e 
…dev-cpp-11
@wbpcode
fix warning under gcc
abc4728 
Signed-off-by: wangbaiping <wbphub@live.com>
@wbpcode
add docs
bc84840 
Signed-off-by: wangbaiping <wbphub@live.com>
wu-sheng
wu-sheng reviewed Aug 12, 2022
View reviewed changes
README.md
@@ -2,7 +2,7 @@

![cpp2sky test](https://github.com/SkyAPM/cpp2sky/workflows/cpp2sky%20test/badge.svg)

Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM
Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM. This SDK is compatible with C++ 17, C++ 14, and C++ 11.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wu-sheng
wu-sheng approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wu-sheng wu-sheng merged commit 7276428 into SkyAPM:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

@wu-sheng wu-sheng

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wbpcode @wu-sheng