Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement log and trace integration #79

Merged
merged 2 commits into from
Jun 14, 2021
Merged

implement log and trace integration #79

merged 2 commits into from
Jun 14, 2021

Conversation

Shikugawa
Copy link
Member

Close #75

@Shikugawa Shikugawa requested a review from wu-sheng June 11, 2021 10:20
wu-sheng
wu-sheng reviewed Jun 11, 2021
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, could this be shared in envoy and make this context available in log and als.

@Shikugawa
Copy link
Member Author

@wu-sheng Yes. It can be integrated with envoy access_log filter. But needed to implement optimizing skywalking usecase.

@wu-sheng wu-sheng added this to the 0.3.0 milestone Jun 14, 2021
@wu-sheng wu-sheng added the enhancement New feature or request label Jun 14, 2021
@wu-sheng wu-sheng merged commit 2e79399 into main Jun 14, 2021
@wu-sheng wu-sheng deleted the log-trace branch June 14, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Log & Trace integration
2 participants
@Shikugawa @wu-sheng