Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

feat: add CreateExitSpanWithContext #126

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

kagaya85
Copy link
Member

@kagaya85 kagaya85 commented Aug 8, 2021

resolve #125

@codecov-commenter
Copy link

Codecov Report

Merging #126 (6a9dfde) into master (ddc26b2) will increase coverage by 0.25%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   69.33%   69.59%   +0.25%     
==========================================
  Files          17       17              
  Lines         887      888       +1     
==========================================
+ Hits          615      618       +3     
+ Misses        224      223       -1     
+ Partials       48       47       -1     
Impacted Files Coverage Δ
trace.go 82.47% <69.23%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc26b2...6a9dfde. Read the comment docs.

@wu-sheng wu-sheng added this to the 1.2.0 milestone Aug 8, 2021
@wu-sheng wu-sheng added the enhancement New feature or request label Aug 8, 2021
Copy link
Member

@rainbend rainbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rainbend rainbend merged commit b16c9f0 into SkyAPM:master Aug 8, 2021
@wu-sheng
Copy link
Member

wu-sheng commented Aug 8, 2021

Quick pull request, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span context is needed after CreateExitSpan
4 participants