Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

fix: close gRPCReporter error if sendCh not nil #131

Merged
merged 3 commits into from
Sep 29, 2021
Merged

fix: close gRPCReporter error if sendCh not nil #131

merged 3 commits into from
Sep 29, 2021

Conversation

lokichoggio
Copy link
Contributor

@wu-sheng wu-sheng requested a review from rainbend September 22, 2021 13:09
@wu-sheng wu-sheng added this to the 1.3.0 milestone Sep 22, 2021
@wu-sheng wu-sheng linked an issue Sep 22, 2021 that may be closed by this pull request
close gRPCReporter error #129
Closed
rainbend
rainbend suggested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@rainbend rainbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lokichoggio conn will not closed if Reporter#Boot is not executed, please check :)

rainbend
rainbend approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@rainbend rainbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rainbend rainbend merged commit 8853e5b into SkyAPM:master Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rainbend rainbend rainbend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

close gRPCReporter error
3 participants
@lokichoggio @rainbend @wu-sheng