Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

add 'Authentication' for grpc request #60

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Conversation

limfriend
Copy link
Contributor

Requirement or improvement
Please describe about your requirements or improvement suggestions.
In some service provider user case, they asked for authentication of agent about data uplink. Add an optional config item in agent side, named auth.token. This token will go with every request.

Related issues
apache/skywalking#934

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is what I need. Can you please fix code format and update the doc?

@codecov-commenter
Copy link

Codecov Report

Merging #60 into master will increase coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   69.91%   70.04%   +0.13%     
==========================================
  Files          14       14              
  Lines         668      671       +3     
==========================================
+ Hits          467      470       +3     
  Misses        160      160              
  Partials       41       41              
Impacted Files Coverage Δ
reporter/grpc.go 61.74% <66.66%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb185d...4b9179b. Read the comment docs.

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Jun 5, 2020
@kezhenxu94 kezhenxu94 added this to the 0.4.0 milestone Jun 5, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit 03a0d51 into SkyAPM:master Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants