Filled Map Fix #60
Merged
Filled Map Fix #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks
Added texture and properties for the Filled Map item
DuckySoLucky
approved these changes
Dec 29, 2024
DuckySoLucky
added a commit
that referenced
this pull request
Dec 30, 2024
* fix(wardobe): moblie and pic ui * update(themes): add fallbacks and fix styling * style(navbar): dark/light mode * style(navbar): fix conditional * style(skills/fishing): fix gold trophy fish color * fix(accessories/enrichments): compare at lower case * fix(dungeons): healer class * fix(inventory): show count * fix(pets): total xp progress * feat(mining): bump hotm tree (#63) * fix(activepet): display name instead of type * style(mining/crystals): color when placed/found * fix(misc/dragons): format fastest kill time * fix(collections): new line inbetween users in tooltip * feat(stats): item container preview (#59) * feat(stats): item container preview * fix(container-preview): update styling * refactor(containedItem): clean code --------- Co-authored-by: zickles <zicklesistaken@gmail.com> * fix(pets): display name * fix(items/armor): armor_name * yes * fix(pets): montezuma pet * feat(pets/display_name): skinned name * fix(minions): dupe tiers * fix(hotm): wrong symbol * fix(inventory): printing open tab * fix(misc/auctions): null check total sold and bought * fix(skills/farming): null check farming tools * refactor(dungeons/bestrun): played -> completed * fix(armor): display set name * fix(stats): percentage * fix(stats): crit chacne * fix(stats): make empty profiles look better and some other small fixes * fix: get rid of console.log() * feat(collections): add completions to dungeon collections * feat(fishing/trophyFish): add progress * feat(seo): integrate svelte-seo for improved SEO management * Filled Map Fix (#60) * Programmer Art Fix Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks * feat(items): add museum viewing & packs * fix(style): prettier * Filled Map Fix Added texture and properties for the Filled Map item --------- Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> --------- Co-authored-by: zickles <zicklesistaken@gmail.com> Co-authored-by: DarthGigi <47110839+DarthGigi@users.noreply.github.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> Co-authored-by: ic22487 <ic22487Gaming@gmail.com>
DuckySoLucky
added a commit
that referenced
this pull request
Dec 30, 2024
* fix(wardobe): moblie and pic ui * update(themes): add fallbacks and fix styling * style(navbar): dark/light mode * style(navbar): fix conditional * style(skills/fishing): fix gold trophy fish color * fix(accessories/enrichments): compare at lower case * fix(dungeons): healer class * fix(inventory): show count * fix(pets): total xp progress * feat(mining): bump hotm tree (#63) * fix(activepet): display name instead of type * style(mining/crystals): color when placed/found * fix(misc/dragons): format fastest kill time * fix(collections): new line inbetween users in tooltip * feat(stats): item container preview (#59) * feat(stats): item container preview * fix(container-preview): update styling * refactor(containedItem): clean code --------- Co-authored-by: zickles <zicklesistaken@gmail.com> * fix(pets): display name * fix(items/armor): armor_name * yes * fix(pets): montezuma pet * feat(pets/display_name): skinned name * fix(minions): dupe tiers * fix(hotm): wrong symbol * fix(inventory): printing open tab * fix(misc/auctions): null check total sold and bought * fix(skills/farming): null check farming tools * refactor(dungeons/bestrun): played -> completed * fix(armor): display set name * fix(stats): percentage * fix(stats): crit chacne * fix(stats): make empty profiles look better and some other small fixes * fix: get rid of console.log() * feat(collections): add completions to dungeon collections * feat(fishing/trophyFish): add progress * feat(seo): integrate svelte-seo for improved SEO management * Filled Map Fix (#60) * Programmer Art Fix Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks * feat(items): add museum viewing & packs * fix(style): prettier * Filled Map Fix Added texture and properties for the Filled Map item --------- Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> * fix(accessories: alias dupes * fix(mining): crystal nucleus runs * fix(pets): pet score * fix(mining/forge): ending time * fix(pets/petscore): montezume pet * fix(items/museum): forgot to pass disabled packs here * refactor: update ABOUT * refactor(SEO): embed * fix(pets): montezuma --------- Co-authored-by: zickles <zicklesistaken@gmail.com> Co-authored-by: DarthGigi <47110839+DarthGigi@users.noreply.github.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> Co-authored-by: ic22487 <ic22487Gaming@gmail.com>
DuckySoLucky
added a commit
that referenced
this pull request
Dec 30, 2024
* fix(wardobe): moblie and pic ui * update(themes): add fallbacks and fix styling * style(navbar): dark/light mode * style(navbar): fix conditional * style(skills/fishing): fix gold trophy fish color * fix(accessories/enrichments): compare at lower case * fix(dungeons): healer class * fix(inventory): show count * fix(pets): total xp progress * feat(mining): bump hotm tree (#63) * fix(activepet): display name instead of type * style(mining/crystals): color when placed/found * fix(misc/dragons): format fastest kill time * fix(collections): new line inbetween users in tooltip * feat(stats): item container preview (#59) * feat(stats): item container preview * fix(container-preview): update styling * refactor(containedItem): clean code --------- Co-authored-by: zickles <zicklesistaken@gmail.com> * fix(pets): display name * fix(items/armor): armor_name * yes * fix(pets): montezuma pet * feat(pets/display_name): skinned name * fix(minions): dupe tiers * fix(hotm): wrong symbol * fix(inventory): printing open tab * fix(misc/auctions): null check total sold and bought * fix(skills/farming): null check farming tools * refactor(dungeons/bestrun): played -> completed * fix(armor): display set name * fix(stats): percentage * fix(stats): crit chacne * fix(stats): make empty profiles look better and some other small fixes * fix: get rid of console.log() * feat(collections): add completions to dungeon collections * feat(fishing/trophyFish): add progress * feat(seo): integrate svelte-seo for improved SEO management * Filled Map Fix (#60) * Programmer Art Fix Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks * feat(items): add museum viewing & packs * fix(style): prettier * Filled Map Fix Added texture and properties for the Filled Map item --------- Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> * fix(accessories: alias dupes * fix(mining): crystal nucleus runs * fix(pets): pet score * fix(mining/forge): ending time * fix(pets/petscore): montezume pet * fix(items/museum): forgot to pass disabled packs here * refactor: update ABOUT * refactor(SEO): embed * fix(pets): montezuma * fix: load the SEO stuff eagerly --------- Co-authored-by: zickles <zicklesistaken@gmail.com> Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> Co-authored-by: ic22487 <ic22487Gaming@gmail.com>
DuckySoLucky
added a commit
that referenced
this pull request
Jan 6, 2025
* fix(wardobe): moblie and pic ui * update(themes): add fallbacks and fix styling * style(navbar): dark/light mode * style(navbar): fix conditional * style(skills/fishing): fix gold trophy fish color * fix(accessories/enrichments): compare at lower case * fix(dungeons): healer class * fix(inventory): show count * fix(pets): total xp progress * feat(mining): bump hotm tree (#63) * fix(activepet): display name instead of type * style(mining/crystals): color when placed/found * fix(misc/dragons): format fastest kill time * fix(collections): new line inbetween users in tooltip * feat(stats): item container preview (#59) * feat(stats): item container preview * fix(container-preview): update styling * refactor(containedItem): clean code --------- Co-authored-by: zickles <zicklesistaken@gmail.com> * fix(pets): display name * fix(items/armor): armor_name * yes * fix(pets): montezuma pet * feat(pets/display_name): skinned name * fix(minions): dupe tiers * fix(hotm): wrong symbol * fix(inventory): printing open tab * fix(misc/auctions): null check total sold and bought * fix(skills/farming): null check farming tools * refactor(dungeons/bestrun): played -> completed * fix(armor): display set name * fix(stats): percentage * fix(stats): crit chacne * fix(stats): make empty profiles look better and some other small fixes * fix: get rid of console.log() * feat(collections): add completions to dungeon collections * feat(fishing/trophyFish): add progress * feat(seo): integrate svelte-seo for improved SEO management * Filled Map Fix (#60) * Programmer Art Fix Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks * feat(items): add museum viewing & packs * fix(style): prettier * Filled Map Fix Added texture and properties for the Filled Map item --------- Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> * fix(accessories: alias dupes * fix(mining): crystal nucleus runs * fix(pets): pet score * fix(mining/forge): ending time * fix(pets/petscore): montezume pet * fix(items/museum): forgot to pass disabled packs here * refactor: update ABOUT * refactor(SEO): embed * fix(pets): montezuma * fix: load the SEO stuff eagerly * fix(misc/mytho): add null checks * fix(accessories): set stat slot * fix(stats/misc): erroring * feat(stats): add API settings * fix(pets): lore * fix(pet milestne): total * fix(hotm): powder * refactor: await this * fix(armor): show all items * yes * chore: update dependencies in package.json * fix(misc): erroring * fix(layouts): adjust z-index values for drawer and popover components * fix(logo): remove debug console logs from logo server handler * fix(styles): update overflow handling in virtual list and adjust whitespace for item display * feat(search): implement search form with validation and enhance functionality * feat(header): conditionally render search form in header for stats page * fix(header): remove debug console log from header component * feat(api-notice): add API notice component to display limited API access information * fix(tooltip): adjust max-height calculations for tooltip and drawer components * fix(layout): adjust backdrop styles and improve layout responsiveness * fix(stats): username whitespace-nowrap * fix(APINotice): is / are * feat(skills): gray it out if API off * fix(themes): fix the wrong colors for themes * feat(Skillbar): API disabled support * is are * fix(Item): simplify conditional rendering structure * fix(Item): remove debug console log for background color * fix(themes): fix the wrong colors for themes second attempt * fix(Item): adjust text size for item count display on different screen sizes * feat(/api/item/): migrate to the new system * fix(/item): use fetch() * feat(stats/rift): add Visits * fix(stats/trophyfishing): golden fish desc * fix(stats/trophyfihsig): descrptions * fix(stats/trophyfish): more desc changesg * feat(stats): add texture_path * feat(itemComponent): add texture pack into desc * fix(settings): remove cookie setting for theme * refactor(skills): svelte 5 * refactor(Item): define Props type for component properties * refactor(itemComponent/pack): minor changes * fix(skillbar): svelte 5 * refactor(ItemComponent): a -> Button, underline text * refactor(item): small changes about pakcs * fix: yes * yes x2 * fix(enchanting): update Collapsible component to default closed state * fix(skillbar): adjust z-index for Tooltip.Trigger component * fix(pets): add + in front of stats * fix(stats): minor fixes * fix(renderLore): dont nextline is last line is nextline * refactor(stats/items): add back gemstones * refactor(Skin3D): streamline onMount logic and introduce onResize function * fix(Rift): update Chip variant based on timecharm unlock status * fix(skin): resizing * chore(deps): add svelte-sonner to dependencies * fix(themes): update theme handling and improve backdrop brightness for better visibility * fix(stats): conditionally render Skin3D component based on window width * Stop streaming profile api response to client * Fix profile context reactivity * feat(toast): implement V2Toast component and integrate with preferences for first-time user notification * Fix window undefined issue * Fix skin reactivity * fix: yes * Fix a couple reactivity issues * fix(layout): add margin to Toaster component for improved spacing * fix(layout): adjust margin of Toaster component for better alignment * fix(layout): remove unnecessary paragraph wrapper from info slot in Items component * Stop using afterNavigate for url rewriting * fix(Wardrobe): refactor Collapsible.Trigger to use asChild for valid HTML (no nested buttons) * revert skin changes --------- Co-authored-by: Kaeso <24925519+ptlthg@users.noreply.github.com> Co-authored-by: zickles <zicklesistaken@gmail.com> Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> Co-authored-by: ic22487 <ic22487Gaming@gmail.com>
DuckySoLucky
added a commit
that referenced
this pull request
Jan 6, 2025
* fix(wardobe): moblie and pic ui * update(themes): add fallbacks and fix styling * style(navbar): dark/light mode * style(navbar): fix conditional * style(skills/fishing): fix gold trophy fish color * fix(accessories/enrichments): compare at lower case * fix(dungeons): healer class * fix(inventory): show count * fix(pets): total xp progress * feat(mining): bump hotm tree (#63) * fix(activepet): display name instead of type * style(mining/crystals): color when placed/found * fix(misc/dragons): format fastest kill time * fix(collections): new line inbetween users in tooltip * feat(stats): item container preview (#59) * feat(stats): item container preview * fix(container-preview): update styling * refactor(containedItem): clean code --------- Co-authored-by: zickles <zicklesistaken@gmail.com> * fix(pets): display name * fix(items/armor): armor_name * yes * fix(pets): montezuma pet * feat(pets/display_name): skinned name * fix(minions): dupe tiers * fix(hotm): wrong symbol * fix(inventory): printing open tab * fix(misc/auctions): null check total sold and bought * fix(skills/farming): null check farming tools * refactor(dungeons/bestrun): played -> completed * fix(armor): display set name * fix(stats): percentage * fix(stats): crit chacne * fix(stats): make empty profiles look better and some other small fixes * fix: get rid of console.log() * feat(collections): add completions to dungeon collections * feat(fishing/trophyFish): add progress * feat(seo): integrate svelte-seo for improved SEO management * Filled Map Fix (#60) * Programmer Art Fix Fixes some items which were using 1.14+ textures, and adds vanilla textures for null blocks * feat(items): add museum viewing & packs * fix(style): prettier * Filled Map Fix Added texture and properties for the Filled Map item --------- Co-authored-by: DuckySoLucky <robertkovac160@gmail.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> * fix(accessories: alias dupes * fix(mining): crystal nucleus runs * fix(pets): pet score * fix(mining/forge): ending time * fix(pets/petscore): montezume pet * fix(items/museum): forgot to pass disabled packs here * refactor: update ABOUT * refactor(SEO): embed * fix(pets): montezuma * fix: load the SEO stuff eagerly * fix(misc/mytho): add null checks * fix(accessories): set stat slot * fix(stats/misc): erroring * feat(stats): add API settings * fix(pets): lore * fix(pet milestne): total * fix(hotm): powder * refactor: await this * fix(armor): show all items * yes * chore: update dependencies in package.json * fix(misc): erroring * fix(layouts): adjust z-index values for drawer and popover components * fix(logo): remove debug console logs from logo server handler * fix(styles): update overflow handling in virtual list and adjust whitespace for item display * feat(search): implement search form with validation and enhance functionality * feat(header): conditionally render search form in header for stats page * fix(header): remove debug console log from header component * feat(api-notice): add API notice component to display limited API access information * fix(tooltip): adjust max-height calculations for tooltip and drawer components * fix(layout): adjust backdrop styles and improve layout responsiveness * fix(stats): username whitespace-nowrap * fix(APINotice): is / are * feat(skills): gray it out if API off * fix(themes): fix the wrong colors for themes * feat(Skillbar): API disabled support * is are * fix(Item): simplify conditional rendering structure * fix(Item): remove debug console log for background color * fix(themes): fix the wrong colors for themes second attempt * fix(Item): adjust text size for item count display on different screen sizes * feat(/api/item/): migrate to the new system * fix(/item): use fetch() * feat(stats/rift): add Visits * fix(stats/trophyfishing): golden fish desc * fix(stats/trophyfihsig): descrptions * fix(stats/trophyfish): more desc changesg * feat(stats): add texture_path * feat(itemComponent): add texture pack into desc * fix(settings): remove cookie setting for theme * refactor(skills): svelte 5 * refactor(Item): define Props type for component properties * refactor(itemComponent/pack): minor changes * fix(skillbar): svelte 5 * refactor(ItemComponent): a -> Button, underline text * refactor(item): small changes about pakcs * fix: yes * yes x2 * fix(enchanting): update Collapsible component to default closed state * fix(skillbar): adjust z-index for Tooltip.Trigger component * fix(pets): add + in front of stats * fix(stats): minor fixes * fix(renderLore): dont nextline is last line is nextline * refactor(stats/items): add back gemstones * refactor(Skin3D): streamline onMount logic and introduce onResize function * fix(Rift): update Chip variant based on timecharm unlock status * fix(skin): resizing * chore(deps): add svelte-sonner to dependencies * fix(themes): update theme handling and improve backdrop brightness for better visibility * fix(stats): conditionally render Skin3D component based on window width * Stop streaming profile api response to client * Fix profile context reactivity * feat(toast): implement V2Toast component and integrate with preferences for first-time user notification * Fix window undefined issue * Fix skin reactivity * fix: yes * Fix a couple reactivity issues * fix(layout): add margin to Toaster component for improved spacing * fix(layout): adjust margin of Toaster component for better alignment * fix(layout): remove unnecessary paragraph wrapper from info slot in Items component * Stop using afterNavigate for url rewriting * fix(Wardrobe): refactor Collapsible.Trigger to use asChild for valid HTML (no nested buttons) * revert skin changes * wth * fix(eslint): unused function * fix(misc/mythos): error when switching profiels --------- Co-authored-by: Kaeso <24925519+ptlthg@users.noreply.github.com> Co-authored-by: zickles <zicklesistaken@gmail.com> Co-authored-by: DarthGigi <47110839+DarthGigi@users.noreply.github.com> Co-authored-by: Zickles <76439587+Zickles@users.noreply.github.com> Co-authored-by: ic22487 <ic22487Gaming@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Filled Map texture and properties