forked from adobe/rules_gitops
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump upstream #12
Open
arturo-skydio
wants to merge
32
commits into
master
Choose a base branch
from
bump-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump upstream #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes additional calls to kubectl that were always using default user * skylib/k8s.bzl changes from michaelschiff/rules_gitops * rename symlink to use_host_config per code review Co-authored-by: Michael Schiff <schiff.michael@gmail.com>
* upgrade bazel deps * buildifier-fix * buildifier * rules_go initialization * always call go_register_toolchains * use named parameter (buildifier) * init go * format * readme
…ible form can be obtained by dropping arguments ["name"] (adobe#105) (13:15:04) DEBUG: Repository k8s_test instantiated at: /root/repo/WORKSPACE:181:11: in <toplevel>
* --dry_run flag * more info on dry run * doc
* secrets example * more commments * buildifier * use array for images
* update go and bazel dependencies * make it work with bazel 6 * deprecate bazel 5.1.1 and switch to 6.0.0 in github actions
* Handle cases where returned object from a watch is not a Pod
If a YAML specifies an empty `initContainers:`, this will crash this code if we also specify yamls. regardless of how pointless this is, this is, it is valid k8s yaml that applies cleanly.
* +use images or image pushes in k8s_deploy images parameter +use dict {"name": ":image" } or [ ":image" ] for images parameter +more tests * correct handling of dependency runtimes * test fixes * use template to generate expected file * cleanup * buildifier * buildifier nit * explain execution_requirements rationale * buildifier Co-authored-by: Konstantin Zadorozhny <kzadorozhny@users.noreply.github.com>
- Tested by running gitops targets in skyops with this repo in local_repository and verifying no changes Topic: upstream-changes Reviewers: daniel-b,holt-w
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in changes from upstream and resolve a few conflicts